Add systematic PRE/POST Tcl hooks for flow steps#3961
Open
Dhirenderchoudhary wants to merge 4 commits intoThe-OpenROAD-Project:masterfrom
Open
Add systematic PRE/POST Tcl hooks for flow steps#3961Dhirenderchoudhary wants to merge 4 commits intoThe-OpenROAD-Project:masterfrom
Dhirenderchoudhary wants to merge 4 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Dhirenderchoudhary
force-pushed
the
fix/pre-post-step-hooks
branch
from
300713a to
d7ad043
Compare
maliberty
requested changes
Mar 6, 2026
Comment on lines
+3
to
5
| source_step_tcl PRE GLOBAL_PLACE | ||
| erase_non_stage_variables place | ||
| load_design 3_2_place_iop.odb 2_floorplan.sdc |
Member
There was a problem hiding this comment.
The pre hook should be after the design is loaded otherwise it is very limited in what it can do. The is the same in all files.
Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
Dhirenderchoudhary
force-pushed
the
fix/pre-post-step-hooks
branch
from
d7ad043 to
c8b1170
Compare
Signed-off-by: Dhirender Choudhary <dhirenderchoudhary0001@gmail.com>
Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
Dhirenderchoudhary
force-pushed
the
fix/pre-post-step-hooks
branch
from
663dc99 to
8443baf
Compare
Author
|
@maliberty fixed as per requirements please have a look |
maliberty
reviewed
Mar 11, 2026
| log_cmd write_sdc -no_timestamp $output_file | ||
| } | ||
|
|
||
| proc source_step_tcl { hook_type step_name } { |
maliberty
reviewed
Mar 11, 2026
Comment on lines
+3
to
+5
| source_step_tcl PRE DETAIL_ROUTE | ||
| load_design 5_1_grt.odb 5_1_grt.sdc | ||
| source_step_tcl PRE DETAIL_ROUTE |
maliberty
reviewed
Mar 11, 2026
Comment on lines
+3
to
+7
| source_step_tcl PRE CTS | ||
| source $::env(SCRIPTS_DIR)/lec_check.tcl | ||
| erase_non_stage_variables cts | ||
| load_design 3_place.odb 3_place.sdc | ||
| source_step_tcl PRE CTS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date : 6 March 2026
Developer name : @Dhirenderchoudhary
Description
Implement systematic PRE/POST Tcl step hooks across ORFS so users can inject custom Tcl before and after each major flow step without editing core scripts.
This adds:
Generic hook resolver helper in flow/scripts/util.tcl
PRE_TCL and POST_TCL sourcing in flow step scripts (synth/floorplan/place/cts/route/final)
Variable metadata entries in flow/scripts/variables.yaml
Regenerated hook documentation in docs/user/FlowVariables.md
Related Issue
Closes #3177
Type of Change
Testing
Checklist